A thing called refactoring
1) I think that phpdig is a great tool.
2) I think that it could benefit *a lot* from a deep refactoring. I took a look at the code, tried to create my own custom_search, then tried to create my own search.php and got disappointed by the low "separation of concern" of the code. Just an example: with the array mode, the search gives back the <a> tag! Oh, yes, config.php let you change the link target... but what about adding other customization to that tag (eg class="myown")? In my (humble) opinion, this is not good software design. And I say this (here) because I like phpdig, and I appreciate the work done so far. Otherwise, I would simply don't mind. Is this the right place to talk about these aspects? Is it possible to discuss about the software design? |
1 Attachment(s)
In the config file, right before:
Code:
// now set $template_demo to clean $template filename or empty string Code:
$template = "array"; |
All times are GMT -8. The time now is 08:22 PM. |
Powered by vBulletin® Version 3.7.3
Copyright ©2000 - 2024, Jelsoft Enterprises Ltd.
Copyright © 2001 - 2005, ThinkDing LLC. All Rights Reserved.