PDA

View Full Version : A thing called refactoring


nobrin
08-19-2005, 03:28 AM
1) I think that phpdig is a great tool.
2) I think that it could benefit *a lot* from a deep refactoring.

I took a look at the code, tried to create my own custom_search, then tried to create my own search.php and got disappointed by the low "separation of concern" of the code.

Just an example: with the array mode, the search gives back the <a> tag!
Oh, yes, config.php let you change the link target... but what about adding other customization to that tag (eg class="myown")?

In my (humble) opinion, this is not good software design. And I say this (here) because I like phpdig, and I appreciate the work done so far. Otherwise, I would simply don't mind.

Is this the right place to talk about these aspects? Is it possible to discuss about the software design?

Charter
08-19-2005, 08:42 AM
In the config file, right before:

// now set $template_demo to clean $template filename or empty string

Set the following:

$template = "array";

Now backup your old custom_search.php, use the original search.php, and then try out the attached file.